Extend handled events #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
design-docs/balanced-call-stack-events-implementation-plan.status.md: Signed-off-by: Tzanko Matev <[email protected]>
codetracer-python-recorder/src/runtime/tracer/events.rs: codetracer-python-recorder/src/runtime/value_capture.rs: codetracer-python-recorder/tests/python/test_monitoring_events.py: design-docs/balanced-call-stack-events-implementation-plan.status.md: Signed-off-by: Tzanko Matev <[email protected]>
codetracer-python-recorder/src/runtime/activation.rs: codetracer-python-recorder/src/runtime/tracer/events.rs: design-docs/balanced-call-stack-events-implementation-plan.status.md: Signed-off-by: Tzanko Matev <[email protected]>
codetracer-python-recorder/src/runtime/tracer/events.rs: codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs: codetracer-python-recorder/tests/python/test_monitoring_events.py: design-docs/balanced-call-stack-events-implementation-plan.status.md: Signed-off-by: Tzanko Matev <[email protected]>
codetracer-python-recorder/tests/python/test_monitoring_events.py: codetracer-python-recorder/tests/rust/print_tracer.rs: design-docs/balanced-call-stack-events-implementation-plan.status.md: Signed-off-by: Tzanko Matev <[email protected]>
…py_unwind, py_resume, py_throw Signed-off-by: Tzanko Matev <[email protected]>
Coverage SummaryRust (lines)
Python (statements)
Generated automatically via |
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we used to only handle
PY_START,PY_RETURNandLINEevents. This lead to an unbalanced call stack in the trace, because we didn't handle exceptions, generators and coroutines properly. We do now. Here's the CHANGELOG entry:PY_YIELD,PY_UNWIND,PY_RESUME, andPY_THROW, mapping resume/throw events toTraceWriter::register_call, yield/unwind toregister_return, and capturingPY_THROWarguments asexceptionusing the existing value encoder. Added Python + Rust integration tests that drive.send()/.throw()on coroutines and generators to guarantee the trace stays balanced and that exception payloads are recorded.